Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy importer wrapper only searches for relative URLs if the URL is not canonicalized #226

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Legacy importer wrapper only searches for relative URLs if the URL is not canonicalized #226

merged 2 commits into from
Jul 1, 2023

Conversation

Goodwine
Copy link
Member

@Goodwine Goodwine commented Jun 7, 2023 •
edited
Loading

@Goodwine Goodwine requested a review from nex3 June 7, 2023 19:24
@Goodwine Goodwine mentioned this pull request Jun 7, 2023
Merged
Goodwine added a commit to sass/dart-sass that referenced this pull request Jun 7, 2023
@Goodwine
Add changelog for sass/embedded-host-node#226
8ff0bea
nex3
nex3 reviewed Jun 9, 2023
View reviewed changes
lib/src/legacy/importer.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@Goodwine Goodwine requested a review from nex3 June 9, 2023 01:30
Goodwine added a commit to sass/dart-sass that referenced this pull request Jun 23, 2023
@Goodwine
Add changelog for sass/embedded-host-node#226
f5334db
@Goodwine Goodwine force-pushed the nested-multiple-imports branch 2 times, most recently from 3ad6d99 to 8400beb Compare June 26, 2023 18:05
@Goodwine Goodwine merged commit 4d0ccbc into main Jul 1, 2023
@Goodwine Goodwine deleted the nested-multiple-imports branch July 1, 2023 02:17
Goodwine added a commit to sass/dart-sass that referenced this pull request Jul 1, 2023
@Goodwine
Add changelog for sass/embedded-host-node#226 (#1992)
78150a9
@TaylorFries TaylorFries mentioned this pull request Aug 10, 2023
Closed
@JaRoD41 JaRoD41 mentioned this pull request Aug 10, 2023
Closed
@cryptoCoder0302 cryptoCoder0302 mentioned this pull request Aug 10, 2023
Open
@Loonz206 Loonz206 mentioned this pull request Aug 10, 2023
Merged
@LukaSL0 LukaSL0 mentioned this pull request Aug 10, 2023
Open
@chakkun1121 chakkun1121 mentioned this pull request Aug 10, 2023
Closed
@MegumiKim MegumiKim mentioned this pull request Aug 10, 2023
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Aug 10, 2023
Open
@btylerburton btylerburton mentioned this pull request Aug 10, 2023
Merged
@solitariusdigital solitariusdigital mentioned this pull request Aug 10, 2023
Closed
@MatthieuFmt MatthieuFmt mentioned this pull request Aug 10, 2023
Open
@ryanwittmers ryanwittmers mentioned this pull request Aug 10, 2023
Open
@sglorch sglorch mentioned this pull request Aug 10, 2023
Closed
@govTechSatish govTechSatish mentioned this pull request Aug 10, 2023
Open
@RajashekarGoudpodeti RajashekarGoudpodeti mentioned this pull request Sep 8, 2023
Open
@krischarbonneau krischarbonneau mentioned this pull request Sep 9, 2023
Closed
@MegumiKim MegumiKim mentioned this pull request Sep 9, 2023
Closed
@rawanst rawanst mentioned this pull request Sep 9, 2023
Open
@ryanwittmers ryanwittmers mentioned this pull request Sep 9, 2023
Open
@brianthiely brianthiely mentioned this pull request Sep 9, 2023
Open
@govTechSatish govTechSatish mentioned this pull request Sep 10, 2023
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Sep 10, 2023
Open
@ae95caba ae95caba mentioned this pull request Sep 10, 2023
Open
@cryptoCoder0302 cryptoCoder0302 mentioned this pull request Sep 10, 2023
Open
@russellcs russellcs mentioned this pull request Sep 10, 2023
Open
@RaoulButler RaoulButler mentioned this pull request Sep 13, 2023
Open
@s-laugh s-laugh mentioned this pull request Sep 13, 2023
Open
@SugandhiKalansooriya SugandhiKalansooriya mentioned this pull request Sep 14, 2023
Open
@Loonz206 Loonz206 mentioned this pull request Sep 18, 2023
Merged
@u-sho u-sho mentioned this pull request Sep 18, 2023
Closed
@amit-rajbhandari amit-rajbhandari mentioned this pull request Sep 21, 2023
Merged
@miro888 miro888 mentioned this pull request Sep 24, 2023
Merged
@0xETHengineer 0xETHengineer mentioned this pull request Sep 24, 2023
Open
@itskarelleh itskarelleh mentioned this pull request Sep 25, 2023
Open
@peterleiva peterleiva mentioned this pull request Sep 26, 2023
Open
@Reshi5 Reshi5 mentioned this pull request Sep 26, 2023
Open
@Nikunz Nikunz mentioned this pull request Sep 28, 2023
Open
@chrlzs chrlzs mentioned this pull request Sep 29, 2023
Merged
@realmarkoprifti realmarkoprifti mentioned this pull request Sep 29, 2023
Open
@Hexy32 Hexy32 mentioned this pull request Sep 30, 2023
Closed
@kingchappers kingchappers mentioned this pull request Oct 1, 2023
Merged
@jkralik jkralik mentioned this pull request Oct 3, 2023
Closed
@Jonasniy Jonasniy mentioned this pull request Oct 4, 2023
Open
@Reiney4 Reiney4 mentioned this pull request Oct 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subsequent import fails in dart-sass-embedded
2 participants
@Goodwine @nex3