Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage on win32-on-arm64 platforms to look for x64 native variant #266

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Correct usage on win32-on-arm64 platforms to look for x64 native variant #266

merged 1 commit into from
Jan 2, 2024

Conversation

chadlwilson
Copy link
Contributor

#265 added support to install the x64 version when on arm64 Windows which is working fine, however there is a typo when determining the compiler path, so you get

Embedded Dart Sass couldn't find the embedded compiler executable. Please make sure the optional dependency sass-embedded-win32-x86 is installed in node_modules

Validated that things work fine with this change on arm64 Windows 11.

nex3 added a commit to sass/dart-sass that referenced this pull request Jan 2, 2024
@nex3 nex3 merged commit 4e43248 into sass:main Jan 2, 2024
16 checks passed
nex3 added a commit to sass/dart-sass that referenced this pull request Jan 2, 2024
@chadlwilson chadlwilson deleted the fix-win-arm64 branch January 2, 2024 23:40
jgerigmeyer added a commit to oddbird/embedded-host-node that referenced this pull request Jan 5, 2024
* main:
  Update Dart Sass version and release
  Look for x64 version on arm64 windows (sass#266)
  Update Dart Sass version and release
  Support musl-libc and android (sass#265)
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Jan 8, 2024
* main:
  Update the pubspec and changelog for sass/embedded-host-node#266 (sass#2158)
  Add wait time before update website (sass#2153)
  Make meta.apply() an AsyncBuiltInCallable (sass#2152)
  Upload releases for musl-libc and android (sass#2149)
  Escape unprintable 0x7F (delete control character) (sass#2144)
  Bump dartdoc from 7.0.2 to 8.0.2 (sass#2146)
jgerigmeyer added a commit to oddbird/embedded-host-node that referenced this pull request Jan 8, 2024
* main:
  Update Dart Sass version and release
  Look for x64 version on arm64 windows (sass#266)
  Update Dart Sass version and release
  Support musl-libc and android (sass#265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants