-
Notifications
You must be signed in to change notification settings - Fork 7
Improve generated Java code #95
base: main
Are you sure you want to change the base?
Conversation
It's not feasible to release 2.0.0 right now, and I'm concerned about releasing a breaking change outside of a major version release. How bad is the current state of the Java generated code? What's the default namespace it uses? |
I'm totally fine if this PR stays open for a while until more important changes justify a new major version. Currently So we get Java class names like The status quo totally works, its just not that elegant and does not follow the java conventions for package names. Generated `.java` files
Compiled `.class` files
With these changes, the output would look like this: New generated `.java` sources
New compiled `.class` files
|
Yeah, unless we can somehow support both let's wait to do this until the next major version. |
These options should improve the java code generated by
protoc
.The package name follows this convention: https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html
From a java point-of-view, this would technically be a breaking change which therefore might require a new major version (2.0.0). For all other languages, this change should be transparent.