Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in interpolating function return values in selectors #1624

Closed
xzyfer opened this issue Oct 25, 2015 · 4 comments · Fixed by #1633
Closed

Regression in interpolating function return values in selectors #1624

xzyfer opened this issue Oct 25, 2015 · 4 comments · Fixed by #1633

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Oct 25, 2015

Originally posted in sass/node-sass#1217.

@function foo($bar) {
  @return $bar;
}

#{foo(foo)} {
  bar: baz;
}

LibSass 3.2.5

foo {
  bar: baz; }

LibSass 3.3.0

"foo" {
  bar: baz; }

Spec added sass/sass-spec#556

@xzyfer xzyfer added this to the 3.3.1 milestone Oct 25, 2015
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 25, 2015
@xzyfer xzyfer changed the title Regression in interpolating selectors Regression in interpolating function return values in selectors Oct 25, 2015
@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 25, 2015

This seems at odds with interpolations always returning a quoted string.
Maybe @chriseppstein can shed some light on the exact semantics here.

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 26, 2015

Ok I had a look at the Ruby source. They explicitly unquote the results of interpolations in ruleset selectors.

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 26, 2015
@xzyfer xzyfer self-assigned this Oct 26, 2015
@chriseppstein
Copy link
Contributor

Ok I had a look at the Ruby source. They explicitly unquote the results of interpolations in ruleset selectors.

It's more general than that. Interpolation always unquotes any quoted string regardless of context.

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 28, 2015

Thanks for the clarification. I mis-remembered our previous discussion and mistaken though the opposite.

Tracking in #1647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants