Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should error on unquote ; inside interpolation #2081

Closed
xzyfer opened this issue May 11, 2016 · 0 comments
Closed

Should error on unquote ; inside interpolation #2081

xzyfer opened this issue May 11, 2016 · 0 comments
Assignees
@mgreter
Labels
Bug - Confirmed Bug - Should Error Dev - PR Ready Dev - Test Written Sass 3.4 Compatibility
Milestone
3.4.x

Comments

@xzyfer
Copy link
Contributor

xzyfer commented May 11, 2016 •
edited by HamptonMakes
Loading

Discovered from #2080

Sass

$foo: #{bar();};

LibSass 3.3.6



Ruby Sass 3.4.21


Invalid CSS after "$foo: #{bar()": expected "}", was ";};"


Spec added sass/sass-spec#913



      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            


    

    

      
    

    


      

          @xzyfer
xzyfer




          added this to the   3.4 milestone


      May 11, 2016

    

  



  

  

    
  


  

      

    @xzyfer
xzyfer



    mentioned this issue
    
      May 11, 2016
    





  


  

      
  
  Closed

  







  




    

    

      
    

    


      

          @xzyfer
xzyfer




          modified the milestones:
      3.4.1, 
      3.4


      Sep 8, 2016

    

  



  


  
    
  
  

    
  xzyfer 

      added a commit
        to xzyfer/sass-spec
      that referenced
      this issue

    
      Sep 8, 2016
    
    

      


  

    

      


  

      
        @xzyfer
  





      

        
          Add specs for issue 2081
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          d03f323
        
      

    

  

    

      
This PR add specs for sass/libsass#2081

    




    

  




  

  

    
  


  

      

    @xzyfer
xzyfer



    mentioned this issue
    
      Sep 8, 2016
    





  


  

      
   Merged

  







  




    


    

    

      
    

    


      

          @xzyfer
xzyfer




          modified the milestones:
      3.4.1, 
      3.4.x


      Dec 28, 2016

    

  



  


  
    
  
  

    
  mgreter 

      added a commit
        to mgreter/libsass
      that referenced
      this issue

    
      Jan 4, 2017
    
    

      


  

    

      


  

      
        @mgreter
  





      

        
          Fix error case with superfluous data in interpolates
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          75933cb
        
      

    

  

    

      
Fixes sass#2081

    




    

  




  


  
    
  
  

    
  mgreter 

      added a commit
        to mgreter/libsass
      that referenced
      this issue

    
      Jan 4, 2017
    
    

      


  

    

      


  

      
        @mgreter
  





      

        
          Fix error case with superfluous data in interpolates
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          456e6f8
        
      

    

  

    

      
Fixes sass#2081

    




    

  




  

  

    
  


  

      

    @mgreter
mgreter



    mentioned this issue
    
      Jan 4, 2017
    





  


  

      
   Merged

  







  




    


    

    

      
    

    


      

          @mgreter
mgreter




              self-assigned this


      Jan 4, 2017

    

  



    

    


  


  
    
  
  

    
  xzyfer 

      pushed a commit
      that referenced
      this issue

    
      Jan 5, 2017
    
    

      


  

    

      


  

      
        @mgreter
      
        @xzyfer
  





      

        
          Fix error case with superfluous data in interpolates
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          1e3c700
        
      

    

  

    

      
Fixes #2081

    




    

  




  


  
    
  
  

    
  xzyfer 

      added a commit
        to xzyfer/sass-spec
      that referenced
      this issue

    
      Jan 5, 2017
    
    

      


  

    

      


  

      
        @xzyfer
  





      

        
          Activate specs for issue 2081
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          082a8ee
        
      

    

  

    

      
This PR activates specs for sass/libsass#2081

    




    

  




  

  

    
  


  

      

    @xzyfer
xzyfer



    mentioned this issue
    
      Jan 5, 2017
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  xzyfer 

      pushed a commit
      that referenced
      this issue

    
      Jan 7, 2017
    
    

      


  

    

      


  

      
        @mgreter
      
        @xzyfer
  





      

        
          Fix error case with superfluous data in interpolates
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          35b7afa
        
      

    

  

    

      
Fixes #2081

    




    

  




  


  
    
  
  

    
  xzyfer 

      pushed a commit
      that referenced
      this issue

    
      Jan 7, 2017
    
    

      


  

    

      


  

      
        @mgreter
      
        @xzyfer
  





      

        
          Fix error case with superfluous data in interpolates
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          ab18e92
        
      

    

  

    

      
Fixes #2081

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @mgreter
  
    mgreter
    

      








      


  


  

    Labels
  



    

      

    Bug - Confirmed

  

    Bug - Should Error

  

    Dev - PR Ready

  

    Dev - Test Written

  

    Sass 3.4 Compatibility









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    3.4.x
  





    
      
          


  

    

      
        

          
    

    Development
  




            
    
No branches or pull requests







      
    

  




      

    

  
      

  

    

      2 participants
    

    

        
          @mgreter 
        
          @xzyfer