We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello
I found a weird behaviour when attempting to fix https://github.com/odoo/enterprise/pull/11881
This CSS is deliberately WRONG.
div { ul:first-child() { font-family: Arial; } }
(can also be tested with :last-child())
:last-child()
libsass 3.6.4 python-libsass 0.19.4
pysassc: error: Error: Custom property values may not be empty. on line 2:8 of test.scss >> ul:first-child() { -------^
I know that my CSS is wrong (in older versions, it would have failed silently. It is good that the compiler now fails on broken CSS).
➡️ the error message that is thrown mentions "custom property values" ➡️ :first-child and :last-child are not "custom properties" as far as I know
:first-child
:last-child
I did some research and found this: #2882
Wouldn't the error message be a side-effect of that change? Shouldn't it be changed to be more explicit and return something like "Invalid CSS" ?
Thanks for your comments, I'm available if you need any other info
The text was updated successfully, but these errors were encountered:
[FIX] web_editor: constant pseudo-classes should not be "called"
ec9e761
In recent versions of libsass, this triggers an error "Custom property values may not be empty" (sass/libsass#3118) which breaks pages.
No branches or pull requests
Hello
I found a weird behaviour when attempting to fix https://github.com/odoo/enterprise/pull/11881
input.scss
This CSS is deliberately WRONG.
(can also be tested with
:last-child()
)Actual results
libsass 3.6.4
python-libsass 0.19.4
Expected result
I know that my CSS is wrong (in older versions, it would have failed silently. It is good that the compiler now fails on broken CSS).
➡️ the error message that is thrown mentions "custom property values"
➡️
:first-child
and:last-child
are not "custom properties" as far as I knowI did some research and found this: #2882
Wouldn't the error message be a side-effect of that change? Shouldn't it be changed to be more explicit and return something like "Invalid CSS" ?
Thanks for your comments, I'm available if you need any other info
The text was updated successfully, but these errors were encountered: