-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS file imports compiled in wrong order #469
Comments
That's definitely weird. I guess we coded the import to float to the top? |
in css "The @import CSS at-rule allows to import style rules from other style sheets. |
It doesn't really matter... Sass 3.4 keeps import below the comment, so we should too. There's very rarely an accident over on the main Sass project. ;) |
@renestalder if i look at the css 2.1 spec, it is 'illegal' after ANY other rule. edit: so, after a comment is not a problem, but it is something to keep in mind. |
https://github.com/sass/sass-spec/tree/master/spec/libsass-todo-issues/issue_469 This now has a test, so the label "needs test" should be removed. |
Also having this issue with what I believe is the current version. I currently have a file with a bunch of settings:
When I try to split that file in multiple imports:
I then start to get a lot of error such as:
Note that the files where those variables are being requested are imported after the settings mentioned above. Not sure what's going on, but this didn't happened with prior versions of libsass. |
This issue should (hopefully) be addressed/fixed by #792. |
@mgreter you can activate the spec for this now! Nice work https://github.com/sass/sass-spec/blob/master/spec/libsass-todo-issues/issue_469 |
What my SCSS file looks like
What the compiled CSS output looks like
The regular CSS import should be bellow the code comment.
In addition, It seems like in compressed mode, instead of the import statement I get the code of the source file. Is this the wanted behaviour?
The text was updated successfully, but these errors were encountered: