libsass doesn't preserve new lines in nested style (Ruby Sass does)

[mgol]

The following SCSS:

a,
div {
    top: 0;
}

is generated by Sass 3.4.5 to the following CSS (when output style is set to nested):

a,
div {
  top: 0; }

/*# sourceMappingURL=styles.css.map */

Meanwhile, libsass 3.0 converts it to:

/* line 2, /Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/app/styles.scss */
a, div {
  top: 0; }

/*# sourceMappingURL=styles.css.map */

Note that a and div are in the same line in the libsass version.

Another issue with this example: #551

[mgol]

Ruby Sass preserves other whitespaces as well, if you e.g. have 4 spaces between selectors in SCSS, they remain 4 in the resulting CSS. libsass collapses them to 1 space.

[mgol]

What does the needs test label mean? I've provided a test case. :)

[HamptonMakes]

If you checkout the Contribution guide in the wiki, it's so that we can write a sass-spec test case that is "todo"

On Sat, Oct 18, 2014 at 2:32 PM, Michał Gołębiowski
notifications@github.com wrote:

What does the needs test label mean? I've provided a test case. :)

Reply to this email directly or view it on GitHub:
#552 (comment)

[mgol]

Another example:

Source:

.a,
.b {
    &.c {
        color: red;
    }
}

Ruby Sass output:

.a.c,
.b.c {
  color: red;
}

libsass output:

.a.c, .b.c {
  color: red; }

[mgol]

A PR to sass-spec: sass/sass-spec#114

[HamptonMakes]

Hmm... just checked and this seems to be passing now on master. @xzyfer did we change anything?

[xzyfer]

This doesn't pass on master for me. I get

Input

a,
div {
    top: 0;
}

.a,
.b {
    &.c {
        color: red;
    }
}

Libsass output

a, div {
  top: 0; }

.a.c, .b.c {
  color: red; }

Ruby sass output

a,
div {
  top: 0; }

.a.c,
.b.c {
  color: red; }

[xzyfer]

My guess is the spec is passing due to this issue in sass-spec sass/sass-spec#131

[mgreter]

The examples here are 100% passing with my latest refactoring! Although there are some other cases where output is not matching exactly and I had to add the "clean" flag to the new tests suite.

[am11]

(I read about the reasoning somewhere libsass issue tracker but forgot what was the consensus). With nested style, libsass converts this:

a{b:c}

to:

a {
  b: c; }

while ruby-sass generates:

a {
  b: c;
}

(with closing parenthesis at new line)

Should this be fixed to conform with the output of ruby-sass?

[mgreter]

Actually with the latest ruby sass this compiles to

a {
  b: c; }

Your example looks like you're compiling it in expanded mode!?

[am11]

Oh my bad. You are right! I was playing with http://sassmeister.com/, forgot to change to nested. :)

Are there plans to add expanded style in LibSass?

[mgreter]

Already done in #910

[am11]

I am an idiot. Sorry and thank you for addressing it! :)

[mgreter]

This should be solved by #910!