-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor contextualize into eval [WIP] #1217
Conversation
938d699
to
e5e003d
Compare
e5e003d
to
9189202
Compare
Needs a clean up but generally speaking it looks sane |
7d12745
to
dd7e37e
Compare
Does your parent selector refactor help with #1210 by any chance? |
Well, it should help to make more sense out of the actual code. I actually did not understand why it was doing what it was doing. So yes, it could help with that, since it is more obvious where and which parent selector we are referring to IMHO. But it really depends on the underlying problem :) |
Took a look at your linked issue and I guess I know how we can fix it. IMHO we need another selector type beside |
This PR add specs for sass/libsass#1217
Ruby Sass explicitly unquotes the results of interpolations in selectors. This patch is very thorough but it address all the use cases I think of and it fixes the regression causing people issues. Fixes sass#1217
Remove contextualize and contextualize_eval by placing the functionallity into eval. Also refactors usage of Parent_Selector and gets rid of Selector_Reference. We now pretty much only store state on the expander itself (selector_stack, env_stack, etc). First iteration that should not break CI.