Refactor for sass_op export on C-API
#1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
refactoring/preparation-for-3.3.1
branch
4 times, most recently
from
07a2c82 to
67b65cb
Compare
|
@mgreter can you help me to figure out why |
mgreter
changed the title
sass_op export on C-API
mgreter
force-pushed
the
refactoring/preparation-for-3.3.1
branch
from
67b65cb to
1333cab
Compare
mgreter
force-pushed
the
refactoring/preparation-for-3.3.1
branch
from
1333cab to
d81920e
Compare
|
If have split the first part of this PR into 3 different PRs: |
mgreter
force-pushed
the
refactoring/preparation-for-3.3.1
branch
3 times, most recently
from
a7791b5 to
0870d51
Compare
mgreter
force-pushed
the
refactoring/preparation-for-3.3.1
branch
from
0870d51 to
dd8a098
Compare
So far only needed to convert selectors!
mgreter
force-pushed
the
refactoring/preparation-for-3.3.1
branch
from
dd8a098 to
a75588a
Compare
Adds new value converter functions.
mgreter
force-pushed
the
refactoring/preparation-for-3.3.1
branch
from
a75588a to
37836b2
Compare
mgreter
added a commit
that referenced
this pull request
Jul 19, 2015
Refactor for `sass_op` export on C-API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out all the safe bits from my latest refactoring state. There are some duplicated code points (like converting values between C and C++). For now the main goal was to have sass ops exposed to the C-API. We also expose a function to stringify any sass value. To check if a value is truthy, you currently have to use an
orcall likesass_op(OR, value, FALSE).