[RFC] Change file fallback from scss to sass syntax
#1341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
changed the title
scss to sass syntaxscss to sass syntax
mgreter
force-pushed
the
change/default-scss-to-sass
branch
from
266046b to
2097c3a
Compare
|
I'd like to hear @chriseppstein thoughts on this. |
|
Maybe we should not rely on extension at all |
|
💯 The code won't help, but here's what I do in wellington. It reads the the input stream looking for non-sass tokens The extension matcher wasn't sufficient to handle stdin or http streams. |
mgreter
force-pushed
the
change/default-scss-to-sass
branch
from
2097c3a to
1431194
Compare
|
Ruby sass relies on the extension, so we probably should keep it that way. I agree there are smarter solutions, but so far we always follow the ruby sass way. So in that sense this change would be legit! |
mgreter
force-pushed
the
change/default-scss-to-sass
branch
from
1431194 to
eefc77a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #1219.
Ruby sass seems to use indented syntax for all file types except
scss. libsass currently does the opposite and recognisessassfile as beeing indented syntax. This PR changes this behavior. It seems to be more inline with ruby sass, but I don't know the implications of this change. I also think we may need to change the force indented syntax flag in this case to force scss syntax.So this is open for feedback and discussion!