Emulate Ruby Sass' url() parsing semantics #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec currently failing is with regards to insignificant whitespace. Not entirely sure how to handle this yet. a {
b: url(data:image/png;base64,iVI= );
}Ruby Sass a {
b: url(data:image/png;base64,iVI= );
}LibSass a {
b: url(data:image/png;base64,iVI=); // no whitespace
} |
xzyfer
force-pushed
the
feat/url-for-reals
branch
2 times, most recently
from
a363780 to
937e459
Compare
We've had countless bugs and regressions with parsing url(). This patch is complete refactor of our url() parsing semantics to 100% match that of Ruby Sass. Fixes sass#674 Spec sass/sass-spec#539
xzyfer
force-pushed
the
feat/url-for-reals
branch
from
937e459 to
b5c91c6
Compare
This was referenced Oct 13, 2015
xzyfer
force-pushed
the
feat/url-for-reals
branch
from
b5c91c6 to
a42df42
Compare
xzyfer
force-pushed
the
feat/url-for-reals
branch
from
a42df42 to
4d3fe32
Compare
xzyfer
added a commit
that referenced
this pull request
Oct 14, 2015
Emulate Ruby Sass' url() parsing semantics
|
Just retested and latest ruby sass seems to give: So this might be fixed already!? |
|
This was fixed in 3.3.
Is fixed in 3.3.3. |
Is fixed in 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had countless bugs and regressions with parsing
url(). Thispatch is complete refactor of our
url()parsing semantics to closermatch that of Ruby Sass.
TODO
url()implement the correct semantics forurl-prefix()determine / implement the correct semantics for@import url()replace uri functions / variables with theirreal_prefixed versionsUpdate: I've reduced the scope of this PR to the regression at hand. This update to
url()semantics will need to applied tourl-prefix()(#1596) and@import url()(#1597) for 3.4.Fixes #674
Spec sass/sass-spec#539