-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extending inner of wrapped selectors (unwrap) #2032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! 👍 |
👍 Thank you! |
6172695
to
4796e00
Compare
@mgreter any objections to releasing 3.3.6 after this is merged? |
@mgreter once these land I'll make sure major projects like foundation, and sassdash still compile as expected. |
@xzyfer just to make sure, you are aware of the "breaking" change here? sass/sass#2036. Reminds me I need to split the spec test I created. |
I wasn't aware, thanks for the link. |
tony
added a commit
to tony/libsass-python
that referenced
this pull request
Apr 24, 2016
This fixes a segfault that happens while compiling materializecss. Its tested with https://github.com/torchbox/django-libsass The bug is documented on the libsass website at sass/libsass#1960 The patch was merge upstream at sass/libsass#2032.
tony
added a commit
to tony/libsass-python
that referenced
this pull request
Apr 24, 2016
This fixes a segfault that happens while compiling materializecss. Its tested with https://github.com/torchbox/django-libsass The bug is documented on the libsass website at sass/libsass#1960 The patch was merge upstream at sass/libsass#2032.
tony
added a commit
to tony/libsass-python
that referenced
this pull request
Apr 24, 2016
This fixes a segfault that happens while compiling materializecss. Its tested with https://github.com/torchbox/django-libsass The bug is documented on the libsass website at sass/libsass#1960 The patch was merge upstream at sass/libsass#2032.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2031
sample
now yields:
ruby sass:
So there is one breaking change from
:not(.asd, .qwe)
to:not(.asd):not(.qwe)
. The first is invalid css so I do not mind shipping this in 3.3.6. I think ruby sass should do it either the same way or produce an error as it does in other situations when it tries to print invalid css syntax.