Error when declarations are printed without ruleset #2061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: Properties are only allowed within rules, directives, mixin includes, or other properties.
|
Let's not do this. This check does not belong in cssize. The cssize class is a 1-1 port from Ruby, no need to change that. Ruby solves this a |
|
IMO this can be moved over once such a |
|
This bug doesn't prevent Sass code being ported to LibSass so IMHO it's a high priority. IMO a fix for this bug is not worth the tech debt. If you really want to fix this it's trivial to add a |
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
May 1, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
May 1, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
May 1, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
changed the title
xzyfer
changed the title
|
Superseeded by #2062 |
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
May 2, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
May 2, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
May 2, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1732 - Another one of the category "should error" ❗
Properties are only allowed within rules, directives, mixin includes, or other properties.