Add support for Source Map Revision 3. #207
Conversation
ghost
mentioned this pull request
|
Thanks, this is awesome! Lemme just grab lunch and wait for the Travis build to finish, then I'll look into merging this in. |
|
Travis failed with autotools. You need to update |
The parser has been adjusted to keep track of the current position (line and column) instead of the current line. The position to the start of the token an AST node is generated from, is stored in the node. During code generation we keep track of the current position in the target file. For each node of interest we create a mapping between the position in the source and target file. Finally, a source map following the Source Map Revision 3 specification can be generated for the collected mappings.
|
I have pushed an update. Let's hope the build will succeed now. |
|
Thanks -- the build failure probably has nothing to do with your pull request; we've just been lax in keeping the Travis script up to date! |
No, @svnieuw added new files to |
|
Hmm, I thought Travis had already been choking on something else.... |
True, there seems to be only about 50% passing, so it should probably be looked into at some point. |
|
Oh yeah, we're running the entire test suite (including the "to-do" tests), so that's expected to fail ... but I thought that Travis wasn't even able to compile for some other reason (like, we were passing the wrong flag to autotools or something). |
But the "to-do" tests don't make up 50% of the tests, so something definitely needs to be checked there. (FYI, the TAP driver in PR #169 correctly understands TODO items.)
Seems to be working fine so far. |
Add support for Source Map Revision 3.
This pull request introduces source map generation.
The generated source map should follow the mapping behavior of the Sass Ruby implementation relatively well. I am looking for people who want to give it a test. Feedback is more than welcome.
@akhleung How should I proceed to get this change merged.