Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make source string const #51

Merged
merged 1 commit into from
Oct 30, 2012
Merged

Make source string const #51

merged 1 commit into from
Oct 30, 2012

Conversation

craigbarnes
Copy link
Contributor

In the C interface, sass_context->source_string is declared as char* but gets const_cast in the library. Does source_string need to be writable? Would it make sense to change it to const char*? It would help to avoid casting or copying when passing a const char* via bindings.

akhleung pushed a commit that referenced this pull request Oct 30, 2012
Merge pull request #51 from craigbarnes/constsrc
a0e50db 
Make source string const
@akhleung akhleung merged commit a0e50db into sass:master Oct 30, 2012
@akhleung
Copy link

Thanks for the fix!

@craigbarnes craigbarnes mentioned this pull request Feb 2, 2015
Closed
@xzyfer xzyfer mentioned this pull request Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigbarnes @akhleung