Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix String_Const unquoting in interpolates #779

Merged
merged 2 commits into from
Dec 27, 2014

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Dec 27, 2014

This is a try to fix #639

It passes all spec tests and additionally makes these tests pass too:

  • spec/libsass-todo-tests/bourbon
  • spec/libsass-todo-tests/libsass/at-stuff

@mgreter mgreter changed the title Fix/string in interpolates Fix String_Const unquoting in interpolates Dec 27, 2014
@xzyfer
Copy link
Contributor

xzyfer commented Dec 27, 2014

@mgreter can you please hold off on merging this for the time being. I'm in the process of making significant updates to the spec suite (sass/sass-spec#207)

@xzyfer xzyfer added this to the 3.1 milestone Dec 27, 2014
@xzyfer
Copy link
Contributor

xzyfer commented Dec 27, 2014

Ok sass-spec has been update! Rebuild this branch in CI and you're good to go!

@xzyfer
Copy link
Contributor

xzyfer commented Dec 27, 2014

I can also confirm spec/libsass-todo-tests/bourbon now passes with this patch.

However spec/libsass-todo-tests/libsass/at-stuff was out of date. It's since been updated and is no longer fixed by this patch.

@mgreter mgreter force-pushed the fix/string-in-interpolates branch from 160d136 to d349d81 Compare December 27, 2014 13:03
mgreter added a commit that referenced this pull request Dec 27, 2014
Fix String_Const unquoting in interpolates
@mgreter mgreter merged commit 5483186 into sass:master Dec 27, 2014
@mgreter mgreter deleted the fix/string-in-interpolates branch December 27, 2014 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpolation mangles up lists
2 participants