Improve interpolate parsing and unquote output #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -686,6 +685,7 @@ namespace Sass { | |||
| const char* static_component(const char* src) { | |||
| return alternatives< identifier, | |||
| static_string, | |||
| percentage, | |||
|
👍 |
|
Another improvement I was able to pull out of my WIP branch. Fixes another todo issue:
|
|
I'm going to merge this now. I already have some other PRs pending, which will adress/improve the naming of the prelexer functions (which @xzyfer correctly pointed out with |
mgreter
added a commit
that referenced
this pull request
Feb 1, 2015
Improve interpolate parsing and unquote output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extracted patch from my current work on the output part.
This should fix the following todo tests:
(It does at least with my WIP branch ...)
And there's more where this is coming from 😉
@xzyfer travis seems to break on the newest added test !?