-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests and cleanup #11
Conversation
@keithamus @nschonni maybe you guys can give me some thoughts on the second test I made. I added |
@ilanbiala Leave it to me this evening and I'll add to this PR, filling out the tests. |
Modifiy tests
@keithamus I just merged in your changes, and all the tests pass, so I'm going to start working on different folders for middleware, but I'll do that in a separate PR. Is |
|
||
# Unix-style newlines with a newline ending every file | ||
[*] | ||
end_of_line = lf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this different from the upstream config https://github.com/sass/node-sass/blob/master/.editorconfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't much different, but it's the editorconfig for this package, which is the same as node-sass's. That should be true, because it's the same org. and style-guide. By the way, it should be space
, not spaces
for indentation style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency we should keep it inline with upstream. Having said that upstream should have the end_of_line
option, which it currently omits (see sass/node-sass#402)
consistent with upstream node-sass
Just modified the .editorconfig so it is consistent with node-sass's. |
LGTM 👍 |
Thanks for your hard work on this @ilanbiala 😄 |
No description provided.