Always write to response

[edwellbrook]

Always write the compiled css to response, but options.response stops the file bring written to disk.

Currently the first request for a stylesheet (before it has been compiled) will 404. On the second run it will use the complied file. My changes mean that the first request will return the compiled css AND write to disk.

For backwards compatibility, using options.response will still write to response, but will not write to disk.

[ilanbiala]

Looks pretty straightforward to me.

[edwellbrook]

@keithamus Hi. Any chance you've been able to look at this?

[ilanbiala]

@keithamus if you guys can't look over this package properly and in a timely fashion, why not allow others to contribute to it and add them as collaborators?

[keithamus]

@ilanbiala there are multiple maintainers for this project, of which I am one. I was a daily user of node-sass but I'm not any more, which means despite having no vested interest in maintaining the project, I still try to find a little free time to help out where I can, mostly to steward the issue tracker, but that is just it - the time is little. In addition it is not my place to say who should and should not be a collaborator on this project.

@edwellbrook Sorry, PRs take a while for me to review due to my lack of free time. I'll take a look when I am next able to, unless another collab beats me to it.

[edwellbrook]

@keithamus No worries. Just checking you were aware of it. Thanks, man!

[nschonni]

There is a bunch of whitespace changes.
Would this do the same for you without duplicating the code

// If response is falsey, write to file
if (!options.response) {
    mkdirp(dirname(cssPath), 0700, function(err){
      if (err) { return error(err); }
      fs.writeFile(cssPath, css, 'utf8', function(err) {
          if (err) return error(err);
      });
    }
}

res.writeHead(200, {
    'Content-Type': 'text/css',
    'Cache-Control': 'max-age=0'
});
return res.end(css);

[edwellbrook]

@nschonni great suggestions thanks. made the changes. let me know what you think!

[nschonni]

LGTM 👍 Do you want to squash the commits down?

[keithamus]

@edwellbrook you seem to have lost the bit where the code actually does fs.writeFile. Perhaps it got swallowed in the squash?

[edwellbrook]

@keithamus I think we're good now. Big apologies for those mess-ups

[keithamus]

Don't sweat it. LGTM 😄

[edwellbrook]

@keithamus Thanks man! 😄

[keithamus]

@edwellbrook thanks for spending your time to make node-sass better!

[edwellbrook]

@keithamus Any idea when this'll be updated on NPM?

[keithamus]

Sorry @edwellbrook, I don't. I don't have the npm publish rights, I believe @andrew does. I'm going to work on getting a travis.yml set up in the next few weeks to autos publish on build.

[ilanbiala]

@keithamus any progress on getting the new commits published in a release on npm?

[keithamus]

@edwellbrook @ilanbiala sorry not yet. Let me try to get the keys to the castle from @andrew

[edwellbrook]

No worries! Thanks :)

[keithamus]

@edwellbrook Ok, @andrew has kindly given me publish rights - I'm going to set it up tonight so that travis can publish to NPM which will mean any contributors who can tag commits can deploy new NPM versions 😄

[edwellbrook]

@keithamus Awesome man! Would be great if you could drop us a message here once it's set up and npm package updated :) Cheers.

[edwellbrook]

Hey @keithamus was this ever updated on npm?

[keithamus]

Waiting for another maintainer to merge #12 - which sets up auto-deploy for this package.

[andrew]

Sorry I missed the boat on that, been avoiding my email a bit for the past week!