Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-sass version - Provides Alpine support #90

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Bump node-sass version - Provides Alpine support #90

merged 1 commit into from
Dec 23, 2016

Conversation

robertfall
Copy link
Contributor

The node-sass project provided Alpine support in 4.1.0.
This change enables the use of node-sass-middleware on Alpine linux as well.

According to the node-sass release notes 4.0.0 is backwards compatible with 3.4.0.

The node-sass project provided Alpine support in 4.1.0. 
This change enables the use of node-sass-middleware on Alpine linux as well.
@xzyfer
Copy link

xzyfer commented Dec 23, 2016

@am11 I can confirm the only change between v3.13.1 and v4.0.0 was the a LibSass bump. There was no BC break in the major bump.

@robertfall
Copy link
Contributor Author

The failing test is the logger test that appears to fail intermittently.

Not sure if there's something I can do to re-run the tests.

@am11
Copy link
Collaborator

am11 commented Dec 23, 2016

Thanks @robertfall! 🎉

The failing test is the logger test that appears to fail intermittently.

These are certainly not related to this change.

@xzyfer, I will push the release tags shortly after tweaking the CLI test timeout (#87 (comment)), i.e. sometime today. 😺

Seems like the test only fails with node.js v0.10 and v0.12.. Will test with nvm on macOS.

@am11 am11 merged commit 8da9850 into sass:master Dec 23, 2016
@robertfall robertfall deleted the patch-2 branch January 4, 2017 09:08
@robertfall
Copy link
Contributor Author

@am11 Do you have an idea when you'll be pushing the tags?

@am11
Copy link
Collaborator

am11 commented Jan 4, 2017

@robertfall, sorry for the delay. Test timeout bug has been fixed and v0.10.1 published to npm registry.

https://github.com/sass/node-sass-middleware/releases/tag/v0.10.1
https://www.npmjs.com/package/node-sass-middleware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants