Skip early and log when prefix mismatches #96
Conversation
|
@jacekkopecky, @silverlight513, can you please take a look? |
am11
force-pushed
the
feature/gh-88-skip-logs
branch
from
a2e59ec to
5454703
Compare
| if (debug) { | ||
| log('error', 'error', errorMessage || err); | ||
| } | ||
| log('error', 'error', errorMessage || err); |
There was a problem hiding this comment.
The severity level error should not be conditioned by debug check. Besides now the condition to check debug flag for severity debug in moved to the log function.
| return compile(); | ||
| } | ||
|
|
||
| // Already compiled, check imports | ||
| checkImports(sassPath, cssStats.mtime, function(changed) { | ||
| if (debug && changed && changed.length) { | ||
| changed.forEach(function(path) { | ||
| log('debug', 'modified import %s', path); | ||
| log('debug', 'compile', path, '(import file) was modified'); |
There was a problem hiding this comment.
Note that %s here was not expanding, now the fourth parameter is interpolated in the flattened log message.
| @@ -285,15 +298,15 @@ module.exports = function(options) { | |||
| } | |||
|
|
|||
| if (sassStats.mtime > cssStats.mtime) { // Source has changed, compile it | |||
| if (debug) { log('debug', 'modified', cssPath); } | |||
| log('debug', 'compile', cssPath, 'was modified'); | |||
There was a problem hiding this comment.
this implies the css was modified, not the scss; should the log have sassPath there instead?
There was a problem hiding this comment.
Thanks for catching this; this is fixed by bf8dfd9.
|
This is very good, nicely consistent and much clearer, yes. Thanks for asking @am11 |
* If the requested file is not .css, log and skip (new: log, we were already skipping here) * If the requested file does not starts with provided prefix, log and prefix (new) * Provide reason for compile logs (new) * Add more logger tests Fixes #88
am11
force-pushed
the
feature/gh-88-skip-logs
branch
from
c95b745 to
c3b12a2
Compare
|
Thanks @jacekkopecky for the review and remarks, much appreciated. The feedback has been addressed. |
|
v0.11.0 has been released. |
|
Happy to help, cheers! |
Fixes #88