Hosting binding.node built using node-chakracore #1776
Comments
Today, `npm install` downloads the pre-built `binding.node` binary from [node-sass repo](https://github.com/sass/node-sass/releases). However these binaries are compiled using `nodev8` and an attempt to use it with [node-chakracore](https://github.com/nodejs/node-chakracore) would fail. One option is to have `node-sass` host binaries pre-built using node-chakracore and during installation have a way to detect the engine (using `process.jsEngine') and download the appropriate engine compliant binary. I have opened sass#1776 to start the discussion for this. For now, as an interim solution, I have disabled downloading the pre-built binary if running with node-chakracore. In `postinstall` stage, it would see that the binary is not present and then would build the binary (only one-time) with node-chakracore.
|
I could be wrong, but I think the best place to get this fixed/compatible would be with https://github.com/nodejs/nan |
|
@nschonni , To give you an analogy, it is like someapp.exe can't work on Ubuntu even if the source code of someapp is same. |
|
Very much looking forward to get getting fixed for the next release so we can use several popular react and react-native projects with node-chakracore. Let me know if any additional testing of the PR is needed before merging. |
|
I want Node Sass to support chakracore but we won't do a half-job of it. It will take a little while, but we will ship aim to ship officially support, not a hack. |
Today, `npm install` downloads the pre-built `binding.node` binary from [node-sass repo](https://github.com/sass/node-sass/releases). However these binaries are compiled using `nodev8` and an attempt to use it with [node-chakracore](https://github.com/nodejs/node-chakracore) would fail. One option is to have `node-sass` host binaries pre-built using node-chakracore and during installation have a way to detect the engine (using `process.jsEngine') and download the appropriate engine compliant binary. I have opened #1776 to start the discussion for this. For now, as an interim solution, I have disabled downloading the pre-built binary if running with node-chakracore. In `postinstall` stage, it would see that the binary is not present and then would build the binary (only one-time) with node-chakracore.
|
Does the release of this tool help move this along? https://github.com/felixrieseberg/windows-build-tools |
|
@matthargett that is unrelated to ChakraCore. nodejs/node-gyp#873 is the most relevant discussion atm |
npm -v): 3.10.3node -v): v7.0.0-pre9node -p process.versions):{ http_parser: '2.7.0', node: '7.0.0-pre9', chakracore: '1.3.0.0', uv: '1.9.1', zlib: '1.2.8', ares: '1.10.1-DEV', modules: '48', openssl: '1.0.2h' }node -p process.platform):win32node -p process.arch):node -p "require('node-sass').info"):npm ls node-sass):When encountering a syntax, or compilation issue:
LibSass. Youmay link it back here, but any change will be required there, not here
Currently
binding.nodereleased are built usingnodejs v8. Developers who want to use node-chakracore, can't rely on this binary and need to build it locally usingnode-chakracore. I would like to start a discussion on what will it take to start hostingbinding.nodethat is built using node-chakracore. Needless to say, this will need some changes in download script insidescripts\install.jsto take care of downloading appropriatebinding.nodebased on node engine that is running the install script.If you delete this text without following it, your issue will be closed.
The text was updated successfully, but these errors were encountered: