omitSourceMapUrl not working?

[temega]

Can't seem to get omitSourceMapUrl to work, never managed to get the url in my .css file while .css.map does get created.

@1.2.2

var runLibsass = function () {
    var stats = {};
    sass.renderFile({
        stats: stats,
        success: function (css) {
            console.log(' > > > > > libsass success', 'strapless.css build success.');
        },
        error: function(error) {
            console.log(' ! ! ! ! ! libsass error', error);
        },
        file: 'sass/main.scss',
        outFile: 'main.css',
        sourceMap: true,
        sourceComment: 'map',
        omitSourceMapUrl: true,
    });
};

[am11]

I can reproduce this issue. This is the issue with omitSourceMapUrl. It happens because our outFile resolving method has a bug, which I will fix for v2.

For workaround, please set the absolute URL in outFile.

A side note: there is no option called sourceComment as in singular, the option sourceComments is Boolean flag, which adds the debug information to the CSS file (it doesn't have any influence on map file), it's a separate feature from couple of releases. So, in your case, if you don't want debug comments in your CSS and simple source-maps, you can just drop sourceComment: 'map', line.

[am11]

This is fixed by d4fa18b via #543.

[andrew]

@am11 you should really only close these issues after the PR has been merged otherwise it confuses people, you can do this automatically by saying "fixes #546" in the PR description.

[am11]

@andrew, alrighty. I thought the v2 label says it all. 😄

[temega]

@am11 Still not working.

First tried an absolute path, didn't work. Then updated to 1.2.3, used relative path, didn't work.

I'm on Windows 7 by the way.

[am11]

@temega, this is added as a v2 feature, which means; it will be made available with node-sass version 2, which is unreleased at the moment.

v1.2.3 did not obtain any new feature. It only has the rebuilt libsass binary.

I'm on Windows 7 by the way.

This should not affect how omitSourceMapUrl behaves.

[michaek]

I'm with @andrew on letting GitHub do the closing by putting "fixes" in the PR description and leaving this one open until its merged.

[am11]

@michaek, just reopened it. I was under the impression that libsass was near to get a next release. But apparently, they have some issues to tackle before vNext. Meanwhile, we can add more features.