Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Consider using node-pre-gyp #766

Closed
saper opened this issue Mar 16, 2015 · 6 comments
Closed

Consider using node-pre-gyp #766

saper opened this issue Mar 16, 2015 · 6 comments

Comments

@saper
Copy link
Member

saper commented Mar 16, 2015

I am somehow frustrated with our scripts.

http://github.com/mapbox/node-pre-gyp could possibly fetch binaries for us, it supports options like --build-from-source and --fallback-to-build

@am11
Copy link
Contributor

am11 commented Mar 16, 2015

Duplicate of #56.

@saper
Copy link
Member Author

saper commented Mar 16, 2015

How is that? It's about getting rid of our scripts/install.js and friends...

@am11
Copy link
Contributor

am11 commented Mar 16, 2015

If you read down, there is mentioning on node-pre-gyp and automating the build process.

@am11
Copy link
Contributor

am11 commented Mar 16, 2015

Also if you search the issue tracker before opening a new issue, you will find that at 33 distinct places, this matter has been discussed. Please read the contributing guideline which begs issue reporter to make use of GH search feature -- coz its pretty awesome! 😎

@saper
Copy link
Member Author

saper commented Mar 16, 2015

People discuss everything everywhere. Bug #56 is about automated build (things like poudriere I am using or vagrant) and not primarily about node-pre-gyp. The guideline recommends specifically that problems should be isolated.

@am11
Copy link
Contributor

am11 commented Mar 16, 2015

That is a guideline for bug. This is a feature suggestion. Suggestions can be broader. Automating the build is what node-pre-gyp do, which is just a "tool". There are other methods available. So please continue this discussion where it belong!

jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
…de-null

Guarded assignments should override null values
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants