-
Notifications
You must be signed in to change notification settings - Fork 1.3k
update to libsass 3.2.0-beta.4 #827
Comments
@fsmanuel, thanks for the offer. I have a very busy week going on. The only stopper is the recent changes in importer. I will try to spend sometime over the weekend. @mgreter, here are the changes I was referring to: am11@55aadd2. It throws at line 11 because // in node-sass dir
require('./').render({
data: '@import \'doesNotExist.scss\'',
importer: function(url, prev, done) {
done({file: url, contents: 's { a: ss; }'});
}
}, function(err, result){
if(err) {
console.log(err); return;
}
console.log(result, result.css.toString());
}); (hopefully missing something fundamental and not the bug in libsass..) Note this is the first step to make the previous implementation just work. Once this passes the existing test suite, I will modify it for multi importers support. |
+1 |
Libsass beta4 had a bug which is fixed in their master. We are waiting on the next nightly. |
v3.0.0-beta.5 is released pointing to libsass v3.2.0-beta.5: https://github.com/sass/node-sass/releases/tag/v3.0.0-beta.5. |
@am11 👍 |
Yay! Great work everyone |
Thanks! Much better now but still not quite working. Specifically, singularitygs doesn't compile yet due to using negative numbers in map's keys: sass/libsass#1086 |
Refactored output to test full buffer for utf8
Hey thanks for the great work.
I run into 'Support parent selector & in values / and/or interpolations' (sass/libsass#548). That seems to be fixed in libsass
3.2.0-beta.4
.Anything I can do to help with a new release that includes libsass
3.2.0-beta.4
?The text was updated successfully, but these errors were encountered: