Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

update to libsass 3.2.0-beta.4 #827

Closed
fsmanuel opened this issue Apr 1, 2015 · 7 comments
Closed

update to libsass 3.2.0-beta.4 #827

fsmanuel opened this issue Apr 1, 2015 · 7 comments

Comments

@fsmanuel
Copy link

fsmanuel commented Apr 1, 2015

Hey thanks for the great work.
I run into 'Support parent selector & in values / and/or interpolations' (sass/libsass#548). That seems to be fixed in libsass 3.2.0-beta.4.
Anything I can do to help with a new release that includes libsass 3.2.0-beta.4?

@am11
Copy link
Contributor

am11 commented Apr 1, 2015

@fsmanuel, thanks for the offer. I have a very busy week going on. The only stopper is the recent changes in importer. I will try to spend sometime over the weekend.

@mgreter, here are the changes I was referring to: am11@55aadd2. It throws at line 11 because Sass_Compiler (comp) is null with the following test:

// in node-sass dir
require('./').render({
  data: '@import \'doesNotExist.scss\'',
  importer: function(url, prev, done) {
    done({file: url, contents: 's { a: ss; }'});
  }
}, function(err, result){
  if(err) {
    console.log(err); return;
  }

  console.log(result, result.css.toString());
});

(hopefully missing something fundamental and not the bug in libsass..)

Note this is the first step to make the previous implementation just work. Once this passes the existing test suite, I will modify it for multi importers support.

@OnkelTem
Copy link

OnkelTem commented Apr 5, 2015

+1
Can't wait to try libsass 3.2.0-beta4

@am11
Copy link
Contributor

am11 commented Apr 5, 2015

Libsass beta4 had a bug which is fixed in their master. We are waiting on the next nightly.

@am11
Copy link
Contributor

am11 commented Apr 6, 2015

v3.0.0-beta.5 is released pointing to libsass v3.2.0-beta.5: https://github.com/sass/node-sass/releases/tag/v3.0.0-beta.5.

@am11 am11 closed this as completed Apr 6, 2015
@fsmanuel
Copy link
Author

fsmanuel commented Apr 6, 2015

@am11 👍

@davidpaulsson
Copy link

Yay! Great work everyone

@OnkelTem
Copy link

Thanks! Much better now but still not quite working. Specifically, singularitygs doesn't compile yet due to using negative numbers in map's keys: sass/libsass#1086

jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
Refactored output to test full buffer for utf8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants