This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Replace deprecated npmconf package. #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously attempted in sass#1413. Shortly after it's release proxy users started experiencing installation issues so this was reverted. It was later determined that sass#1458 was likely at fault for the proxy issues. Full credit for this patch goes to @delitescere. I've also taken the liberty of cleaning the request config generation. Fixes sass#1333
xzyfer
force-pushed
the
feat/replace-npmconf
branch
from
1f013b7
to
265fdae
Compare
|
LGTM |
|
I'll release this on a the
|
|
YOLO |
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Fix escape sequence parsing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously attempted in #1413. Shortly after it's
release proxy users started experiencing installation issues (#1458)
so this was reverted. It was later determined that #1458 was likely
at fault for the proxy issues.
Full credit for this patch goes to @delitescere.
I've also taken the liberty of cleaning the request config generation.
Fixes #1333