Enable install and build using node-chakracore

.travis.yml

@@ -1,45 +1,77 @@
 language: node_js
-
+dist: trusty
 compiler: gcc
 sudo: false
 
 env:
   global:
+    # https://github.com/jasongin/nvs/blob/master/doc/CI.md
+    - NVS_VERSION=1.3.0
     - SKIP_SASS_BINARY_DOWNLOAD_FOR_CI=true
 
 jobs:
   include:
     - stage: test
-      node_js: "node"
+      env:
+        global:
+          - NODEJS_VERSION: node/6
       os: linux
       before_script: npm run lint || exit 1;
       after_success: npm run-script coverage;
     - stage: platform-test
-      node_js: "node"
+      env:
+        global:
+          - NODEJS_VERSION: node/8
       os: osx    
     - stage: platform-test
-      node_js: "7"
+      env:
+        global:
+          - NODEJS_VERSION: node/7
       os: linux
     - stage: platform-test
-      node_js: "7"
+      env:
+        global:
+          - NODEJS_VERSION: node/7
       os: osx
     - stage: platform-test
-      node_js: "lts/boron"
+      env:
+        global:
+          - NODEJS_VERSION: node/boron
       os: linux
     - stage: platform-test
-      node_js: "lts/boron"
+      env:
+        global:
+          - NODEJS_VERSION: node/boron
       os: osx
     - stage: platform-test
-      node_js: "lts/argon"
+      env:
+        global:
+          - NODEJS_VERSION: node/argon
       os: linux
     - stage: platform-test
-      node_js: "lts/argon"
+      env:
+        global:
+          - NODEJS_VERSION: node/argon
       os: osx
     - stage: platform-test
-      node_js: "0.12"
+      env:
+        global:
+          - NODEJS_VERSION: node/0.12
+      os: linux
+    - stage: platform-test
+      env:
+        global:
+          - NODEJS_VERSION: node/0.10
       os: linux
     - stage: platform-test
-      node_js: "0.10"
+      env:
+        global:
+          - NODEJS_VERSION: chakracore/latest
+      os: osx
+    - stage: platform-test
+      env:
+        global:
+          - NODEJS_VERSION: chakracore/latest
       os: linux
 
 addons:
@@ -51,14 +83,25 @@ addons:
       - g++-4.7
 
 before_install:
+  # Install NVS.
+  - git clone --branch v$NVS_VERSION --depth 1 https://github.com/jasongin/nvs ~/.nvs
+  - . ~/.nvs/nvs.sh
+  - nvs --version
+
+  # Install selected version of Node.js using NVS
+  - nvs add $NODEJS_VERSION
+  - nvs use $NODEJS_VERSION
+  - node --version
+  - npm --version
+
   - npm config set python `which python`
   - if [ $TRAVIS_OS_NAME == "linux" ]; then
       export CC="gcc-4.7";
       export CXX="g++-4.7";
       export LINK="gcc-4.7";
       export LINKXX="g++-4.7";
     fi
-  - nvm --version
+
   - node --version
   - npm --version
   - gcc --version

appveyor.yml

@@ -32,44 +32,53 @@
     - '%AppData%\npm-cache'
 
   environment:
+    # https://github.com/jasongin/nvs/blob/master/doc/CI.md
+    NVS_VERSION: 1.3.0
     SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
     matrix:
-      - nodejs_version: 0.10
-        GYP_MSVS_VERSION: 2013
-        APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
-      - nodejs_version: 0.12
+      - NODEJS_VERSION: node/0.10
         GYP_MSVS_VERSION: 2013
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
-      - nodejs_version: 1.0
+      - NODEJS_VERSION: node/0.12
         GYP_MSVS_VERSION: 2013
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
-      - nodejs_version: 1
+      - NODEJS_VERSION: iojs/1
         GYP_MSVS_VERSION: 2013
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
-      - nodejs_version: 2
+      - NODEJS_VERSION: iojs/2
         GYP_MSVS_VERSION: 2013
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
-      - nodejs_version: 3
+      - NODEJS_VERSION: iojs/3
         GYP_MSVS_VERSION: 2013
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
-      - nodejs_version: 4
+      - NODEJS_VERSION: node/4
         GYP_MSVS_VERSION: 2013
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
-      - nodejs_version: 5
+      - NODEJS_VERSION: node/5
         GYP_MSVS_VERSION: 2013
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
-      - nodejs_version: 6
+      - NODEJS_VERSION: node/6
         GYP_MSVS_VERSION: 2015
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-      - nodejs_version: 7
+      - NODEJS_VERSION: node/7
         GYP_MSVS_VERSION: 2015
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-      - nodejs_version: 8
+      - NODEJS_VERSION: node/8
         GYP_MSVS_VERSION: 2015
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
+      - NODEJS_VERSION: chakracore/latest
+        GYP_MSVS_VERSION: 2015
+        APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015        
 
   install:
-    - ps: Install-Product node $env:nodejs_version $env:platform
+    # Install NVS
+    - git clone --branch v%NVS_VERSION% --depth 1 https://github.com/jasongin/nvs %LOCALAPPDATA%\nvs
+    - set PATH=%LOCALAPPDATA%\nvs;%PATH%
+    - nvs --version
+    # Install selected version of Node.js using NVS
+    - nvs add %NODEJS_VERSION%
+    - nvs use %NODEJS_VERSION%  
+
     - node --version
     - npm --version
     - npm install

lib/extensions.js

@@ -196,10 +196,16 @@ function getBinaryName() {
     }
 
     binaryName = [
-      platform, '-',
-      process.arch, '-',
-      process.versions.modules
-    ].join('');
+      platform,
+      process.arch,
+      process.versions.modules,
+    ];
+
+    if (process.jsEngine === 'chakracore') {
+      binaryName = binaryName.concat(process.jsEngine);
+    }
+
+    binaryName = binaryName.join('-');
   }
 
   return [binaryName, 'binding.node'].join('_');

scripts/build.js

@@ -56,14 +56,20 @@ function afterBuild(options) {
  */
 
 function build(options) {
-  var args = [require.resolve(path.join('node-gyp', 'bin', 'node-gyp.js')), 'rebuild', '--verbose'].concat(
-    ['libsass_ext', 'libsass_cflags', 'libsass_ldflags', 'libsass_library'].map(function(subject) {
-      return ['--', subject, '=', process.env[subject.toUpperCase()] || ''].join('');
-    })).concat(options.args);
-
-  console.log('Building:', [process.execPath].concat(args).join(' '));
-
-  var proc = spawn(process.execPath, args, {
+  var nodeGyp = resolveNodeGyp();
+  var nodeGypArgs = nodeGyp.args.concat([
+    'rebuild',
+    '--verbose',
+    '--libsass_ext=' + (process.env['LIBSASS_EXT'] || ''),
+    '--libsass_cflags=' + (process.env['LIBSASS_CFLAGS'] || ''),
+    '--libsass_ldflags=' + (process.env['LIBSASS_LDFLAGS'] || ''),
+    '--libsass_library=' + (process.env['LIBSASS_LIBRARY'] || ''),
+  ])
+  .concat(options.args);
+
+  console.log(['Building:', nodeGyp.exeName].concat(nodeGypArgs).join(' '));
+
+  var proc = spawn(nodeGyp.exeName, nodeGypArgs, {
     stdio: [0, 1, 2]
   });
 
@@ -83,6 +89,40 @@ function build(options) {
   });
 }
 
+/**
+ * Resolve node-gyp command to invoke
+ *
+ * @api private
+ */
+function resolveNodeGyp() {
+  if (process.jsEngine === 'chakracore') {
+    // For node-chakracore, check if node-gyp is in the path.
+    // If yes, use it instead of using node-gyp directly from
+    // node_modules because the one in node_modules is not
+    // compatible with node-chakracore.
+    var nodePath = path.dirname(process.execPath);
+    var nodeGypName = process.platform === 'win32' ? 'node-gyp.cmd' : 'node-gyp';
+    var globalNodeGypBin = process.env.Path.split(';').filter(function(envPath) {
+      return envPath.startsWith(nodePath) &&
+               envPath.endsWith('node-gyp-bin') &&
+               fs.existsSync(path.resolve(envPath, nodeGypName));
+    });
+
+    if (globalNodeGypBin.length !== 0) {
+      return { exeName: 'node-gyp', args: [] };
+    }
+
+    console.error('node-gyp incompatible with node-chakracore! Please use node-gyp installed with node-chakracore.');
+    process.exit(1);
+  }
+
+  var localNodeGypBin = require.resolve(path.join('node-gyp', 'bin', 'node-gyp.js'));
+
+  return {
+    exeName: process.execPath,
+    args: [localNodeGypBin],
+  };
+}
 /**
  * Parse arguments
  *