Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Normalize drive letter #2179

Closed
wants to merge 2 commits into from
Closed

Normalize drive letter #2179

wants to merge 2 commits into from

Conversation

MLoughry
Copy link
Contributor

@MLoughry MLoughry commented Dec 5, 2017

This is a follow-up to #2149.

I did not realize true-case-path did not normalize the drive letter, which can cause the same issues as described in #1895. The project does not seem to be maintained any longer, so I've removed the dependency and copied the code here with one small change to normalize the drive letter.

@nschonni
Copy link
Contributor

nschonni commented Dec 5, 2017

Due to the license, we can't just copy/paste this in https://github.com/barsh/true-case-path/blob/master/LICENSE
The next major of node-sass will also likely be dropping all our custom download and binding code for node-pre-gyp, so I'm going to close this

@nschonni nschonni closed this Dec 5, 2017
@MLoughry
Copy link
Contributor Author

MLoughry commented Dec 5, 2017

Hmmm. Your repo, your call; but the code for that package is sourced entirely from a StackOverflow post. I'm not sure how they can claim license over it.

https://stackoverflow.com/questions/33086985/how-to-obtain-case-exact-path-of-a-file-in-node-js-on-windows/33139702#33139702

@MLoughry
Copy link
Contributor Author

MLoughry commented Dec 5, 2017

Is there a timeline for the next major version?

@nschonni
Copy link
Contributor

nschonni commented Dec 6, 2017

Hmmm. Your repo, your call; but the code for that package is sourced entirely from a StackOverflow post. I'm not sure how they can claim license over it.

🤷‍♂️ barsh/true-case-path#1

For the v5 stuff, we're discussing it over in #2111
I think the main thing is getting libsass to cut a stable 3.5 release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants