-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Respect quiet option in Node API #2268
Conversation
xzyfer
commented
Mar 4, 2018
•
edited
Loading
edited
- Emit normal output as info not warn
- Don't emit info output in quiet mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think the linked issue is asking about something else since Grunt wouldn't be calling through the bin
You're totally right. The issue is confusing. |
I agree this isn't related the the tagged issue (now removed), but it still the correct behaviour. |
@xzyfer Thanks a lot for the 'warn' > 'info' change, the useless warning output in our build process was always confusing. It would be nice to change it here, too: https://github.com/sass/node-sass/blob/master/lib/render.js |
Great suggestion. We're open to PRs, otherwise we'll try to get it sorted
in v5
…On Tue., 17 Apr. 2018, 12:38 am Aicke Schulz, ***@***.***> wrote:
@xzyfer <https://github.com/xzyfer> Thanks a lot for the 'warn' > 'info'
change, the useless warning output in our build process was always
confusing.
It would be nice to change it here, too:
https://github.com/sass/node-sass/blob/master/lib/render.js
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2268 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWFWyqJRMPfZ44tvxQsRePfUI29zsks5tpKz8gaJpZM4SbKPP>
.
|
This is an extension of #2268. Catches a few places missed the first time around.
Addressed in #2344. |
This is an extension of #2268. Catches a few places missed the first time around.
While troubleshooting CLI watcher tests (for #2560 and #2479 I have noticed that this and #2344 has a bad side-effect. Watcher messages go out now to standard output instead of to standard error. This breaks the following (seldom) usage:
Our (currently skipped) watcher tests expect that CSS output will be delivered to stdout. I have filed #2755 about this |