Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

when watching entire directory, don't rebuild files outside said directory #2492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/node-sass
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ function watch(options, emitter) {
});

files.changed.forEach(function(file) {
if (path.basename(file)[0] !== '_') {
var srcDir = options.directory && path.join(process.cwd(), options.directory);
var isInclude = srcDir && file.indexOf(srcDir) === -1;
if (path.basename(file)[0] !== '_' && !isInclude) {
renderFile(file, options, emitter);
}
});
Expand Down
25 changes: 25 additions & 0 deletions test/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,31 @@ describe('cli', function() {
}, 200);
}, 500);
});

it.skip('should not compile changed files outside watched directory', function(done) {
var rootDir = fixture('watching-dir-03/');
var destDir = fixture('watching-dir-03/dest');
var srcDir = fixture('watching-dir-03/src');
var outsideFile = path.join(rootDir, 'outside.scss');

fs.writeFileSync(outsideFile, '');

var bin = spawn(cli, [
'--output', destDir,
'--watch', srcDir
]);

setTimeout(function () {
fs.appendFileSync(outsideFile, 'body{background:white}\n');
setTimeout(function () {
bin.kill();
var files = fs.readdirSync(rootDir);
assert.deepEqual(files, [ 'dest', 'outside.scss', 'src' ]);
rimraf(destDir, done);
}, 200);
}, 500);
});

});

describe('node-sass in.scss --output out.css', function() {
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/watching-dir-03/outside.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
body{background:white}
1 change: 1 addition & 0 deletions test/fixtures/watching-dir-03/src/index.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@import "outside";