This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Bump node-gyp; disable binary builds in CI for old Node #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically this is a breaking change for Node < 4. We still see a bananas amount of downloads for Node 0.10 on CI - presumably CI environments. The breakage is limited only to building the binaries locally. This means node-sass will continue to install, and operate as normal on all our support Node 0.10 and 0.12 environments. IMHO this is a fair trade off to address the `npm audit` noise without the disruption of forcing a major version bump before we're ready.
|
CI seems happy but I cannot get the AppVeyor build to start. Happy to deal with AppVeyor once this is on master. |
14 tasks
|
Waiting to see how this develops isaacs/node-tar#212 |
xzyfer
changed the title
This comment has been minimized.
This comment has been minimized.
|
Closing since the tar issue is resolved. In v5 it will probably get bumped or replaced with node-pre-gyp instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically this is a breaking change for Node < 4. We still see
a bananas amount of downloads for Node 0.10 on CI - presumably CI
environments.
The breakage is limited only to building the binaries locally. This
means node-sass will continue to install, and operate as normal on
all our support Node 0.10 and 0.12 environments.
IMHO this is a fair trade off to address the
npm auditnoise withoutthe disruption of forcing a major version bump before we're ready.
Unfortunately this means any LibSass updates are going to be a huge pain!
Attempt to fix #2625