[DNM] Bump C++ standard to C++14 #3091
Conversation
- Bump to 5.1.0 - Add CI builds for 16 - Add extension lookup for module 93
Bumps [actions/setup-node](https://github.com/actions/setup-node) from v2.1.2 to v2.1.3. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.2...27082ce) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from v2.1.3 to v2.1.4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.3...c46424e) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from v2.1.4 to v2.1.5. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.4...46071b5) Signed-off-by: dependabot[bot] <support@github.com>
saper
force-pushed
the
upgrade-cpp-standard-to-14
branch
from
9be2da4
to
12d935a
Compare
| @@ -28,7 +28,7 @@ | |||
| } | |||
| }, | |||
| 'xcode_settings': { | |||
| 'CLANG_CXX_LANGUAGE_STANDARD': 'c++11', | |||
| 'CLANG_CXX_LANGUAGE_STANDARD': 'c++14', | |||
There was a problem hiding this comment.
Should/do we need to condition this so it only applies to Node 16?
There was a problem hiding this comment.
Good question. They obviously build, but we should check if they work on old platforms.
There was a problem hiding this comment.
I think the other patch that @xzyfer pointed to in the other thread just dropped the line entirely. I wonder if that makes sense either.
I'm good with going with the 14 if it makes sense, since I think you've got more c++ experience than me 😄
There was a problem hiding this comment.
I'd rather not change the things for previous versions because we know the resulting binaries are problem free and I have the rocker containers to build them ready
There was a problem hiding this comment.
Our team is using node-sass v4.12.0 and have been unable to compile node-sass.
We manually changed line 31 to 'CLANG_CXX_LANGUAGE_STANDARD': 'c++14' and we were able to overcome the 'remove_cv_t' error with xcode.
There was a problem hiding this comment.
We manually changed line 31 to
'CLANG_CXX_LANGUAGE_STANDARD': 'c++14'and we were able to overcome the 'remove_cv_t' error with xcode.
Which node version were you on?
There was a problem hiding this comment.
Looks like there is canonical answer for which cxx which should be targeting for each Node version at https://github.com/nodejs/node/blob/master/BUILDING.md#official-binary-platforms-and-toolchains
Lots of the decisions in our gyp configuration were made back in the node 0.11 / 0.12 days and cludged on since then to just make it work from them on.
There was a problem hiding this comment.
We manually changed line 31 to
'CLANG_CXX_LANGUAGE_STANDARD': 'c++14'and we were able to overcome the 'remove_cv_t' error with xcode.Which node version were you on?
We are on Node v14.15.1.
After reading the compatible version table on the readme, we deleted node_modules folder and package-lock.json, upgraded to node-sass 4.14 and still encountered the same error and fixed it with the same solution.
…al node-sass upgrade is being discussed by contributors (changing C++ binding configuration in node_modules sass/node-sass#3091), but due to project timeline, removing node-sass entirely is the solution chosen Co-authored-by: Justin Baik <bij3377@gmail.com> Co-authored-by: Max Weisenberger <germanbluemax@gmail.com> Co-authored-by: Mo Hmaidi <mhmaidi789@gmail.com>
|
if i simply pass i'm running on archlinux. i'll probably just downgrade node to v15 until this is settled. |
|
Is there still movement on this? The need for Node v16 compatibility is becoming more important now that it is the active LTS; Github Actions have updated a few days ago (actions/runner-images#4446), for example. |
Never mind, https://github.com/sass/node-sass/releases/tag/v6.0.0 seems to have solved this. |
No description provided.