Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Install: Use npmconf to get proxy config #616

Merged
merged 1 commit into from
Jan 11, 2015
Merged

Install: Use npmconf to get proxy config #616

merged 1 commit into from
Jan 11, 2015

Conversation

am11
Copy link
Contributor

@am11 am11 commented Jan 10, 2015

Fixed #588.

//cc @kevva

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 64bd7b8 on am11:master into 0add991 on sass:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2cc36c4 on am11:master into f5f48bd on sass:master.

@am11
Copy link
Contributor Author

am11 commented Jan 10, 2015

@kevva, so does it LGTY? :)
Its time for v2.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 07b3571 on am11:master into 97e1563 on sass:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 07b3571 on am11:master into 97e1563 on sass:master.

am11 added a commit that referenced this pull request Jan 11, 2015
Install: Use npmconf to get proxy config
@am11 am11 merged commit 0e5cdc3 into sass:master Jan 11, 2015
@kevva
Copy link
Member

kevva commented Jan 11, 2015

👍

@am11
Copy link
Contributor Author

am11 commented Jan 14, 2015

@kevva is @api a legal jsdoc block type (identifier)? I could not find that one on http://usejsdoc.org/.

On that note, I think we need @returns across the board. :)

@kevva
Copy link
Member

kevva commented Jan 14, 2015

@am11, I think it's http://usejsdoc.org/tags-access.html but I've always used @api for some reason.

@am11
Copy link
Contributor Author

am11 commented Jan 14, 2015

Perhaps we can submit a proposal somewhere for @access [private / public / protected / internal]. :)

Or even better: @scope [private / public / protected / internal].

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tunneling socket could not be established, cause=Parse Error
3 participants