Build: Produces identifiable binary name #657

am11 · 2015-02-10T07:51:39Z

The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: #655.

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

xzyfer · 2015-02-10T07:59:17Z

lib/utils.js

+module.exports.getBinaryIdentifiableName = function() {
+  return process.platform + '-' +
+         process.arch + '-' +
+         runtime + '-' +


Looks like you factored out runtime

LOL yes and one more thing. Repushing now 😃

xzyfer · 2015-02-10T07:59:55Z

Will this approach handle things that aren't node or io, like atom shell?

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 · 2015-02-10T08:17:45Z

@xzyfer, I have not yet looked into atom shell yet. We can incorporate it later. However, we can add binary for io.js in node-sass-binaries v2.0.0.

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

xzyfer · 2015-02-10T08:18:49Z

Yep! It's definitely a step forward

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

coveralls · 2015-02-10T08:26:37Z

Coverage increased (+0.28%) to 92.59% when pulling 2be25ba on am11:master into 9c3accb on sass:master.

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

coveralls · 2015-02-10T08:30:40Z

Coverage increased (+0.28%) to 92.59% when pulling 4b5ebaf on am11:master into 9c3accb on sass:master.

am11 · 2015-02-10T08:58:59Z

lib/index.js

@@ -8,11 +9,10 @@ var fs = require('fs'),
 */

 function getBinding() {
-  var name = process.platform + '-' + process.arch;
  var candidates = [
    path.join(__dirname, '..', 'build', 'Release', 'binding.node'),
    path.join(__dirname, '..', 'build', 'Debug', 'binding.node'),


@xzyfer, @kevva,
I think Debug should take precedence over Release here; because if you explicitly build Debug binary with node-gyp rebuild -d, then your primary intent is to debug that binary in debug mode. :)

because if you explicitly build Debug binary with node-gyp rebuild -d , then your primary intent is to debug that binary in debug mode

Build: Produces identifiable binary name

am11 · 2015-02-10T10:11:01Z

@xzyfer, tested with atom shell, it returns win32-ia32-atom-1.0. 😏

xzyfer · 2015-02-10T10:20:57Z

Nailed it 👍
On 10 Feb 2015 21:11, "Adeel Mujahid" notifications@github.com wrote:

@xzyfer https://github.com/xzyfer, tested with atom shell, it returns
win32-ia32-atom-1.0. [image: 😏]

—
Reply to this email directly or view it on GitHub
#657 (comment).

am11 force-pushed the master branch from dbd4965 to b6ee845 Compare February 10, 2015 07:53

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

b6ee845

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from b6ee845 to b66aa3b Compare February 10, 2015 07:54

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

b66aa3b

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from b66aa3b to f5f05cd Compare February 10, 2015 07:57

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

f5f05cd

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

xzyfer reviewed Feb 10, 2015
View reviewed changes

am11 force-pushed the master branch from f5f05cd to a919a7a Compare February 10, 2015 08:02

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

a919a7a

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from a919a7a to 57c9078 Compare February 10, 2015 08:09

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

57c9078

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from 57c9078 to b2a5443 Compare February 10, 2015 08:11

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

b2a5443

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from b2a5443 to 8cf4540 Compare February 10, 2015 08:11

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

8cf4540

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from 8cf4540 to 269f4b4 Compare February 10, 2015 08:13

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

269f4b4

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from 269f4b4 to b8a6309 Compare February 10, 2015 08:18

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

b8a6309

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from b8a6309 to 0923568 Compare February 10, 2015 08:18

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

0923568

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from 0923568 to 2be25ba Compare February 10, 2015 08:23

am11 added a commit to am11/node-sass that referenced this pull request Feb 10, 2015

Build: Produces identifiable binary name.

2be25ba

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

Build: Produces identifiable binary name.

4b5ebaf

The new format is: {platform}-{arch}-{runtime}-{major.minor} where major and minor version belong to the runtime. Related Issue: sass#655. PR URL: sass#657.

am11 force-pushed the master branch from 2be25ba to 4b5ebaf Compare February 10, 2015 08:27

am11 reviewed Feb 10, 2015
View reviewed changes

Code: Prioritises Debug over Release.

110cfc7

am11 added a commit that referenced this pull request Feb 10, 2015

Merge pull request #657 from am11/master

1180417

Build: Produces identifiable binary name

am11 merged commit 1180417 into sass:master Feb 10, 2015

renovate bot mentioned this pull request Jun 6, 2021

Update dependency node-sass to v6 - autoclosed zce/SmartControl#49

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build: Produces identifiable binary name #657

Build: Produces identifiable binary name #657

am11 commented Feb 10, 2015

xzyfer Feb 10, 2015

am11 Feb 10, 2015

xzyfer commented Feb 10, 2015

am11 commented Feb 10, 2015

xzyfer commented Feb 10, 2015

coveralls commented Feb 10, 2015

coveralls commented Feb 10, 2015

am11 Feb 10, 2015

kevva Feb 10, 2015

am11 Feb 10, 2015

am11 commented Feb 10, 2015

xzyfer commented Feb 10, 2015

Build: Produces identifiable binary name #657

Build: Produces identifiable binary name #657

Conversation

am11 commented Feb 10, 2015

xzyfer Feb 10, 2015

Choose a reason for hiding this comment

am11 Feb 10, 2015

Choose a reason for hiding this comment

xzyfer commented Feb 10, 2015

am11 commented Feb 10, 2015

xzyfer commented Feb 10, 2015

coveralls commented Feb 10, 2015

coveralls commented Feb 10, 2015

am11 Feb 10, 2015

Choose a reason for hiding this comment

kevva Feb 10, 2015

Choose a reason for hiding this comment

am11 Feb 10, 2015

Choose a reason for hiding this comment

am11 commented Feb 10, 2015

xzyfer commented Feb 10, 2015