Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Submodule: Updates LibSass to v3.2.0-beta.1 #764

Merged
merged 1 commit into from
Mar 18, 2015

Conversation

am11
Copy link
Contributor

@am11 am11 commented Mar 15, 2015

@am11 am11 added the Dev - WIP label Mar 15, 2015
@am11 am11 added this to the 3.0 milestone Mar 15, 2015
@am11
Copy link
Contributor Author

am11 commented Mar 15, 2015

@mgreter, the source-map tests are failing as I updated the submodule. I couldn't find info about the related changes in v3.2.0-beta.1 changelog. The issue is with the file member in .map file. We pass (resolved) absolute paths to libsass, so it can resolve .css path with respect to .map location.
FWIW, all those tests were passing with libsass v3.1.0.

To wit:

node-sass v3.0.0-pre which corresponds to libsass v3.1.0:

cd /tmp
git clone https://github.com/sass/node-sass --recursive
cd node-sass
git checkout tags/v3.0.0-pre
git submodule update --init --recursive
npm install
node scripts/build -f
npm test
# all passed! :)

vs. libsass v3.2.0-beta.1:

cd /tmp
git clone libsass-v3.2.0-beta.1 https://github.com/am11/node-sass --recursive
# ^my branch
cd node-sass
git submodule update --init --recursive
npm install
node scripts/build -f
npm test
# source-map related tests failed.. :(

@am11 am11 force-pushed the libsass-v3.2.0-beta.1 branch 2 times, most recently from 54266fd to 1dc306e Compare March 18, 2015 13:58
@am11 am11 force-pushed the libsass-v3.2.0-beta.1 branch 4 times, most recently from 86593f2 to 53a06de Compare March 18, 2015 16:11
* Updates sass-spec to corresponding commit.
* Prevents source_string from freeing in
  data context case in binding code.
  * Corresponds to sass/libsass#925.
@am11 am11 force-pushed the libsass-v3.2.0-beta.1 branch from 53a06de to e243c8e Compare March 18, 2015 16:13
am11 added a commit that referenced this pull request Mar 18, 2015
Submodule: Updates LibSass to v3.2.0-beta.1
@am11 am11 merged commit 8c641f4 into sass:master Mar 18, 2015
@am11 am11 deleted the libsass-v3.2.0-beta.1 branch March 18, 2015 17:09
@am11 am11 removed the Dev - WIP label Mar 18, 2015
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
…otes

str-slice and str-insert should normalise quote to double quotes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant