-
Notifications
You must be signed in to change notification settings - Fork 1.3k
API: Provides support for array of importers #832
Conversation
@mgreter, going by perl-libsass and C-API documentation for importers, what is the purpose of last parameter |
@am11 if the loaded content has a sourcemap accociated, you should return the content of the sourcemap in that variable. We don't do anything with it yet, but in the future libsass should remap the resulting css to the provided source-map if possible. |
@mgreter, perfect! I will expose that feature to node-sass API in this PR then. :) |
@am11 any ETA when you will release the next beta, so libsass can do another beta round too? |
@mgreter, I am almost ready. Can you please release a beta with the |
@am11 lets move that discussion to sass/libsass#1020 😉 |
I have added the I will do the final rebase once libsass next rc/beta is released.. |
* In order to skip the importer, user must return `sass.types.NULL` (or the shorter alias `sass.NULL`). * See the added test on usage. * Backward compatible: part of me want still wants to make it non-backward compatible because: * We can: in major version v3.0. * It will keep the API clean. * It will keep the docs clear: type of `options.importers` is array of functions. * Updates docs. Issue URL: sass#821. PR URL: sass#832.
* Also updates dependencies versions.
* In order to skip the importer, user must return `sass.types.NULL` (or the shorter alias `sass.NULL`). * See the added test on usage. * Backward compatible: part of me want still wants to make it non-backward compatible because: * We can: in major version v3.0. * It will keep the API clean. * It will keep the docs clear: type of `options.importers` is array of functions. * Updates docs. Issue URL: sass#821. PR URL: sass#832.
API: Provides support for array of importers
Update the native number function signatures to match Ruby sass 3.4.9
return
sass.types.NULL
(or the shorteralias
sass.NULL
).wants to make it non-backward compatible
because:
options.importers
is array of functions.Issue URL: #821.