Switch to Chokidar.

[paulmillr]

Closes gh-636. Tests fail because of something else.

To summarize: chokidar is very stable, doesn't have 52 open issues and is much faster on OSX, with less CPU usage because of fsevents.

[am11]

Thanks for the contribution! :)

It is failing AppVeyor CI Windows tests because npm writes warnings to stderr, AppVeyor chokes on switching sub-processes (like npm install) within a job, if anything was written on stderr. One solution is to try-catch the require() of optionalDependencies in Chokidar's code. With the current state of this PR, it will prevent us from running ~750 tests on Windows based CI.

[paulmillr]

We do this already. https://github.com/paulmillr/chokidar/blob/master/lib/fsevents-handler.js

In fact, it was failing before this commit.

[paulmillr]

Hmm I think I saw some packages that use chokidar and are tested by appveyor. Need to find these

[paulmillr]

Here's a quick example https://github.com/AppGyver/steroids/blob/master/package.json

Chokidar is tested by it too :) https://github.com/paulmillr/chokidar/blob/master/appveyor.yml

[am11]

Hmm, then I think we should remove ps from appveyor.yml#L23.

In fact, it was failing before this commit.

Nope, the current master is not failing: https://ci.appveyor.com/project/sass/node-sass/build/889.

[paulmillr]

Ah, i've meant the tests are failing on my machine. I will provide logs later (were doing npm test)

[am11]

Ping 🔔
{{Pong}}

[paulmillr]

@am11 what's required from me? That doesn't seem like Chokidar error.

Just tested it locally — all tests pass.

[am11]

Just remove ps: prefix, not the entire statement.

- npm install --msvs_version=2013

[am11]

LGTM!
Thanks @paulmillr. 👍

@xzyfer, if this has been triaged with CI tests, then it can probably be considered for vNext as a non-breaking infrastructure change. Thoughts?

[paulmillr]

@xzyfer ping.

[marlun]

Curious on that status of this ticket since when installing node-sass now you get a warning that it uses a deprecated version of lodash. The reason is that node-sass is using an old version of gaze (0.5.* instead of 0.6.*). Maybe you could try the new version until you change to Chokidar?

[xzyfer]

We've been waiting to see if Chokidar would gain traction.

As for gaze, the latest dist-tag is current 0.5.2. If/when the maintainer updates the 0.6.x to be latest we'll update.

[paulmillr]

@xzyfer curious what do you actually mean by "traction".

chokidar: 463202 downloads in the last week
gaze: 376144 downloads in the last week

[xzyfer]

@paulmillr I understand what you're saying. Chokidar has clearly gained traction since this PR opened.

To be more explicit there are a couple reasons we have not moved forward on this:

• our current watcher gives us little to no trouble
• most people use gulp or grunt watch for node-sass

At the moment, as far as I know, neither grunt or gulp has switch to chokidar in their stable releases.
I am also aware that gulp has switched to chokidar in their unstable 4 branch, which is exciting.

Once gulp 4 is stable a large portion of our user base will be using chokidar and the migration will be a much smaller support risk.

I hope you understand. We're a very small team and we hugely appreciate your contribution.

[saper]

We also had to make a one step back - all tests for the CLI watcher have been removed, because they were poorly written. We will need those tests back.

[lo1tuma]

Any update on this?

[michaelwayman]

in the meantime checkout https://github.com/michaelwayman/node-sass-chokidar

npm install node-sass-chokidar

[realityking]

I think this has been taken care of with 80fc103

[xzyfer]

Correct

[paulmillr]

😸

[mcmire]

Hey, what's the status on this? It seems like node-sass is still using Gaze and the commit linked to wasn't in fact merged in. Did it get reverted?

[tofran]

@mcmire Looks like it has been merged to v5 more information in #2111

[mcmire]

Ooh, good to hear! Thanks!

[realityking]

It looks like this didn't land in the final v5 release. What happened?