Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document first-class mixins #852
Document first-class mixins #852
Changes from 1 commit
b3ed1dc
c676c97
bda5e34
dde90f1
cc5039f
4762e36
212ca48
ae9a114
9ab36f8
a41c2e6
45d535e
6f59a2d
75dde5f
4c39d3f
7cdecf8
504b362
152e344
06de720
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it that
meta.get-mixin(my-module.my-mixin)
won't return anything because it should have been written asmeta.get-mixin(my-module, my-mixin)
, is that right?I think it might be helpful to call that out, but I realize
get-function
doesn't, so maybe that's OK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait and see if users actually make that mistake before we add extra text for it. I don't think I've seen anyone do that with
meta.get-function()
.