-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specs for @forward ... with #1499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
<===> | ||
================================================================================ | ||
<===> with/before_as/input.scss | ||
@forward "other" with ($a: b) as c-*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is the same with @use
currently - but I don’t see it documented clearly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sass-spec/spec/directives/use/error/syntax.hrx
Lines 515 to 525 in 0749da4
<===> with/before_as/input.scss | |
@use "other" with ($a: b) as c; | |
<===> with/before_as/error | |
Error: expected ";". | |
, | |
1 | @use "other" with ($a: b) as c; | |
| ^ | |
' | |
input.scss 1:27 root stylesheet |
😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha - I guess I was referring to user-facing documentation that these phrases have a set order :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, user-facing documentation is not 100% thorough—we gloss over some details that are unlikely to matter in order to keep it readable and beginner-friendly. The prose specification is where you should look for the most thorough and rigorous documentation, and it's also clear about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be good to add some specs for the interaction between @forward ... with
and @import
.
Done. |
See sass/sass#2744
[skip dart-sass]