Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for @forward ... with #1499

Merged
merged 3 commits into from
Dec 20, 2019
Merged

Add specs for @forward ... with #1499

merged 3 commits into from
Dec 20, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Nov 28, 2019

See sass/sass#2744

[skip dart-sass]

Copy link
Contributor

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

<===>
================================================================================
<===> with/before_as/input.scss
@forward "other" with ($a: b) as c-*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is the same with @use currently - but I don’t see it documented clearly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<===> with/before_as/input.scss
@use "other" with ($a: b) as c;
<===> with/before_as/error
Error: expected ";".
,
1 | @use "other" with ($a: b) as c;
| ^
'
input.scss 1:27 root stylesheet

😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha - I guess I was referring to user-facing documentation that these phrases have a set order :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, user-facing documentation is not 100% thorough—we gloss over some details that are unlikely to matter in order to keep it readable and beginner-friendly. The prose specification is where you should look for the most thorough and rigorous documentation, and it's also clear about this.

Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be good to add some specs for the interaction between @forward ... with and @import.

@nex3
Copy link
Contributor Author

nex3 commented Dec 18, 2019

It would also be good to add some specs for the interaction between @forward ... with and @import.

Done.

@nex3 nex3 merged commit e9e219b into master Dec 20, 2019
@nex3 nex3 deleted the forward-with branch December 20, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants