Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic shared tests for the JS API compile functions #1716

Merged
merged 2 commits into from
Oct 2, 2021
Merged

Add basic shared tests for the JS API compile functions #1716

merged 2 commits into from
Oct 2, 2021

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 21, 2021 •
edited
Loading

[skip dart-sass]

@nex3 nex3 marked this pull request as draft September 21, 2021 23:41
@nex3 nex3 force-pushed the compile-specs branch 2 times, most recently from ddaf3e3 to 5e48e52 Compare September 23, 2021 01:37
@nex3 nex3 requested a review from Awjin September 23, 2021 01:37
@nex3 nex3 marked this pull request as ready for review September 23, 2021 01:37
@nex3 nex3 force-pushed the compile-specs branch 2 times, most recently from cbe1290 to dd58f6b Compare September 23, 2021 05:58
@nex3 nex3 mentioned this pull request Sep 23, 2021
Closed
5 tasks
Awjin
Awjin approved these changes Oct 1, 2021
View reviewed changes
js-api-spec/compile.test.ts Outdated Show resolved Hide resolved
@nex3
Update js-api-spec/compile.test.ts
280ffe4 
Co-authored-by: Awjin Ahn <awjin@google.com>
@nex3 nex3 merged commit 94477a2 into main Oct 2, 2021
@nex3 nex3 deleted the compile-specs branch October 2, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awjin Awjin Awjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @Awjin