Activate specs for broken at-root in LibSass #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR activates specs for sass/libsass#2006
This PR activates specs for sass/libsass#2198
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
Oct 4, 2016
LibSass fully parses selectors during the parsing stage. This is different from Ruby Sass which parse selectors and string during the parsing stage, and lazily eval'ing when required. This difference causes some pathological selector issues. Our eager parsing of selectors has resulted in us hacking in fake `Parent_Selector` into `Sequence_Selector` during parsing. These fake `Parent_Selector` play havoc with `resolve_parent_refs` when within `@at-root` blocks. I spent a couple weeks going down the rabbit whole of refactoring our selector parsing to be lazy before bailing. Explicitly marking which `Parent_Selector` are fake during parsing allows us faithfully implement the `implicit_parent` flag in `resolve_parent_refs`. Fixes sass#2006 Fixes sass#2198 Spec sass/sass-spec#936
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
Oct 4, 2016
LibSass fully parses selectors during the parsing stage. This is different from Ruby Sass which parse selectors and string during the parsing stage, and lazily eval'ing when required. This difference causes some pathological selector issues. Our eager parsing of selectors has resulted in us hacking in fake `Parent_Selector` into `Sequence_Selector` during parsing. These fake `Parent_Selector` play havoc with `resolve_parent_refs` when within `@at-root` blocks. I spent a couple weeks going down the rabbit whole of refactoring our selector parsing to be lazy before bailing. Explicitly marking which `Parent_Selector` are fake during parsing allows us faithfully implement the `implicit_parent` flag in `resolve_parent_refs`. Fixes sass#2006 Fixes sass#2198 Spec sass/sass-spec#936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates specs for sass/libsass#2006 and sass/libsass#2198