-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build native extensions on M1 #223
Conversation
Hello, just a friendly poke. Based on https://github.com/sass/sassc-ruby/graphs/contributors perhaps @bolandrm or @eregon could help? |
Friendly ping here. 👋 |
if enable_config('march-tune-native', false) | ||
# darwin arm doesn't support native | ||
# see: https://github.com/sass/sassc-ruby/issues/222 | ||
if enable_config('march-tune-native', false) && Gem::Platform.local.cpu != 'arm64' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is already false
, why is this change needed?
Upon further investigation, this issue only exists in versions prior to v2.3.0. It's not clear which commit fixes it, but this does address this error:
|
Per your comment, it was probably #158 |
We already support disabling this compilation flag anyway, so might as well just do it automatically for architectures that don't support it.