-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0: Remove dependency on Ruby Sass #85
Conversation
@csuhta I know there may be some extraneous code here in the |
@bolandrm Tests pass, so if you are happy with it currently, we can merge. (You're also totally good with the 2.0.0 version bump and the new requirement to use Ruby 2.3.3 or higher too?) |
@csuhta why exactly do we need to specify the ruby version? |
@bolandrm Without |
@bolandrm I've pushed a few more changes and I think this is in much better shape:
|
🎉 thanks @csuhta !! |
Remove dependency on Ruby Sass sass/sassc-ruby#85
This is a WIP pull request, but I would like to get your thoughts on these things, some of them still in progress:sass
)SassC::SyntaxError
to replace the Sass error class treeCacheStores
(this doesn't seem to be needed anymore?)SassC::Script::Value::*
class code from Ruby Sass to free the dependency. This code also includes a lot of functionality to implement Ruby Sass properly, not just the FFI interface, so I need to finish auditing all of it for what we don't actually need to bring to this gemcc #75