win: Converts ANSI argv to UTF8 array #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spec added: sass/sass-spec#640. |
|
@am11 do you have merge powers? If so merge at your discretion. If not I'll
|
|
@xzyfer, nope I don't have the merge access. |
xzyfer
added a commit
that referenced
this pull request
Dec 27, 2015
Converts ANSI argv to UTF8 array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing sass/libsass#1774, I found another issue with UTF8 and sassc on Windows: the
char** argvdisregards the Unicode/multibyte characters passed through stdin. Note that sass/libsass#1774 is not dependent on this by the reciprocal is true.Also added a missing
&in windows build steps doc.