Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak by freeing options we allocated #196

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Oct 19, 2016

Needs sass/libsass#2213

Allocated on line 230 by sass_make_options

@mgreter
Copy link
Contributor Author

mgreter commented Oct 19, 2016

# valgrind --leak-check=full sassc/bin/sassc sassc/foo.scss
==3514== Memcheck, a memory error detector
==3514== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==3514== Using Valgrind-3.10.1 and LibVEX; rerun with -h for copyright info
==3514== Command: sassc/bin/sassc sassc/foo.scss
==3514==
foo-bar {
  baz: baz; }
==3514==
==3514== HEAP SUMMARY:
==3514==     in use at exit: 0 bytes in 0 blocks
==3514==   total heap usage: 2,403 allocs, 2,403 frees, 166,497 bytes allocated
==3514==
==3514== All heap blocks were freed -- no leaks are possible
==3514==
==3514== For counts of detected and suppressed errors, rerun with: -v
==3514== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

@mgreter mgreter self-assigned this Oct 19, 2016
@mgreter mgreter merged commit 112fc62 into sass:master Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant