Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return 'None' as a property value #12

Open
pombredanne opened this issue Jun 12, 2017 · 3 comments
Open

Do not return 'None' as a property value #12

pombredanne opened this issue Jun 12, 2017 · 3 comments
Labels
enhancement

Comments

@pombredanne
Copy link
Contributor

The code here:

pymaven/pymaven/pom.py

Line 336 in f99a287

properties['parent.version'] = str(self.parent.version)
will return 'None' for a property if the value of the attribute is None.
pombredanne added a commit to aboutcode-org/pymaven that referenced this issue Jun 12, 2017
@pombredanne
Do not stringify empty attributes sassoftware#12
bc77f53 
 * instead check first if the value exist and only stringify if this
   is the case (this avoids returning 'None' as string).

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue Jun 16, 2017
Closed
@wfscheper
Copy link
Contributor

If you convert your commit into a pull request, I'll merge it.

@pombredanne
Copy link
Contributor Author

@wfscheper I will, as clean commit off the https://github.com/sassoftware/pymaven/tree/clientless-pom branch

@wfscheper
Copy link
Contributor

@pombredanne, now that the project is unarchived, I was hoping to quickly merge any changes from your fork that address the open issues. My plan in the short-term is to modernize some of the project infrastructure (packaging, CI, etc), but getting these outstanding issues addressed will be easier if we fix them first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wfscheper @pombredanne