Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (IAC-1119) add a description for all Terraform outputs without one #215

Merged

Conversation

luigidifraiawork
Copy link
Contributor

@luigidifraiawork luigidifraiawork commented Jun 21, 2023

Changes

Enable the terraform_documented_outputs tflint rule and update the output.tf files to ensure each output has a description.

Tests

Ran through infrastructure creation with this PR, there are no functional changes just adding descriptions

@luigidifraiawork luigidifraiawork force-pushed the feat/add-output-descriptions branch from 6dab74f to 5494014 Compare July 5, 2023 22:17
@thpang thpang changed the base branch from main to staging July 18, 2023 12:54
@sayeun sayeun changed the title docs: add a description for all Terraform outputs without one feat: (IAC-1119) add a description for all Terraform outputs without one Jul 19, 2023
Signed-off-by: Luigi Di Fraia <luigidifraia+workrelated@gmail.com>
@jarpat jarpat force-pushed the feat/add-output-descriptions branch from fe78f1e to 3e49935 Compare December 1, 2023 15:14
@jarpat jarpat added the enhancement New feature or request label Dec 1, 2023
@jarpat jarpat changed the title feat: (IAC-1119) add a description for all Terraform outputs without one chore: (IAC-1119) add a description for all Terraform outputs without one Dec 7, 2023
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit b682480 into sassoftware:staging Dec 8, 2023
@jarpat jarpat mentioned this pull request Dec 12, 2023
dhoucgitter pushed a commit that referenced this pull request Feb 28, 2024
… one (#215)

Signed-off-by: Luigi Di Fraia <luigidifraia+workrelated@gmail.com>
Co-authored-by: jarpat <jay.patel@sas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants