-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-mergeable-selectors incorrectly trying to merge two selectors in different mixins #339
Comments
Yeah, i need to look at mixins as part of #307 anyway so I'll combine the effort then |
Ah yeah, I see they're related. |
Same issue here. Although a slightly different test case for me -- one inside a mixin.
|
Yeah, I'm hoping to look at this soon, it's going to be a little bit of a refactor it looks like. |
Same issue here with media queries: .spacing {
margin: 16px 0;
&.spacing-sm {margin: 8px 0;}
@media only screen and (max-width: 767px) {
margin: 8px 0;
&.spacing-sm {margin: 5px 0;}
}
}
.spacing-bottom {
margin-bottom: 32px;
&.spacing-sm {margin-bottom: 15px;}
@media only screen and (max-width: 767px) {
margin-bottom: 15px;
&.spacing-sm {margin-bottom: 10px;} // sass-lint triggers here
// and suggests merging with the rule in the media query of .spacing
}
} |
Don't worry, this is in progress and should be resolved in our 1.6 update which we're hoping to get to you soon. |
@tonifisler @bgriffith @brokentone All of your examples are fixed in the rewrite of the mergeable selectors rule released with sass-lint 1.6.0! |
This rule incorrectly tries to merge two selectors within two different mixins.
SassLint: 1.3.1
The text was updated successfully, but these errors were encountered: