Gonzales 3.2 - Fix no mergeable selectors #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| else if (val.is('atkeyword') ) { | ||
| content = constructSubSelector(val, '@', '', constructSelector); | ||
|
|
|
Also fixes #559 |
bgriffith
added a commit
that referenced
this pull request
Mar 2, 2016
Gonzales 3.2 - Fix no mergeable selectors
|
👍 👍 👍 👍 👍 👍 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last rule update for gonzales 3.2 incoming! Sorry it took so long to get round to..
Fixes the no-mergeable-selectors rule for gonzales 3.2 and also closes #495 and #339 and #307 while we're at it.
Warning messages stay the same but most of the method for this has changed and attaches itself to the root stylesheet traverse of gonzales so should be easier to extend/fix in the future.
Please note though that
Sasssyntax still has some fairly serious issues, which we get around in this rule by ignoring at rules completely whereasscssformat will report on them.All tests now passing!
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com